Merge master-localization into master#16249
Merged
Merged
Conversation
From build https://ls.jenkins.autodesk.com/job/CL/job/DynamoCore_CL/405/ Professional translation: all languages Pseudo translation: none
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges updated localization branches into master, aligning localized resource files with the English originals.
- Adds a new
WebRequestOfflineWarningentry in all NodeServices resource files for Polish, Korean, Japanese, Italian, French, Spanish, German, and Czech. - Introduces a
DownloadPackageDisabledentry in all DynamoPackages resource files, currently as an English placeholder.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
| File Pattern | Description |
|---|---|
| src/NodeServices/Properties/Resources.*.resx | Add WebRequestOfflineWarning placeholder entry |
| src/DynamoPackages/Properties/Resources.*.resx | Add DownloadPackageDisabled placeholder entry |
Comments suppressed due to low confidence (2)
src/DynamoPackages/Properties/Resources.zh-TW.resx:127
- This entry is currently in English; please provide the localized translation to avoid shipping English text in a zh-TW resource file.
<value>Package download is disabled in no-network mode.</value>
src/DynamoPackages/Properties/Resources.zh-TW.resx:126
- [nitpick] Indentation of this
<data>element does not match surrounding entries; align it with the existing 4-space indent level for consistency.
<data name="DownloadPackageDisabled" xml:space="preserve">
QilongTang
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi , could you please review and merge this PR?
================== Word Count Statistics begin ==================
GMT Fri May 30 07:40:16 2025: Localization Engineer Lead for this PR is lilian.rossi@autodesk.com,MOR-REVIT-SLEs@moravia.com.
Vendor Engineer for this PR is MOR-REVIT-SLEs@moravia.com.
Localization branch is updated.
New/Updated strings status
CHS: 2 strings (14 words) are in English
CHT: 2 strings (14 words) are in English
CSY: 2 strings (14 words) are in English
DEU: 2 strings (14 words) are in English
ESP: 2 strings (14 words) are in English
FRA: 2 strings (14 words) are in English
ITA: 2 strings (14 words) are in English
JPN: 2 strings (14 words) are in English
KOR: 2 strings (14 words) are in English
PLK: 2 strings (14 words) are in English
PTB: 2 strings (14 words) are in English
RUS: 2 strings (14 words) are in English
Please note that If the word count above shows some words in English, it is because the localization team hasn't processed all the new/updated strings yet. These words will be translated in the next translation loop.
Please merge this PR anyway as it will align the localizable file(s) content with the English file(s) content and prevent any functionality issue caused from misaligned localized file(s) versus English file(s).
If you are about to release and you are concerned about these strings showing up in English, please contact your localization contact/project team. Thanks.
=================== Word Count Statistics end ==================